Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Fix typo in setBitrate method. #48

Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix(types): Fix typo in setBitrate method. #48

merged 1 commit into from
Dec 8, 2020

Conversation

armand1m
Copy link
Contributor

@armand1m armand1m commented Dec 2, 2020

Fixes a typo in the type definitions. This is probably a big deal for typescript users.

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@armand1m
fix(types): Fix typo in setBitrate method.
8fdffbb 
Fixes a typo in the type definitions. This is probably a big deal for typescript users.
@armand1m
Copy link
Contributor Author

armand1m commented Dec 4, 2020 •
edited
Loading

@SpaceEEC thanks for approving! can you merge this? maybe @iCrawl ?

@iCrawl iCrawl merged commit d2df1ca into discordjs:master Dec 8, 2020
@armand1m armand1m deleted the patch-1 branch December 9, 2020 10:50
@armand1m
Copy link
Contributor Author

armand1m commented Dec 9, 2020

@iCrawl thanks for merging! when are you planning to release this?

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
semver:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armand1m @vladfrangu @SpaceEEC @iCrawl