-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): use Agent with higher connect timeout #8679
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #8679 +/- ##
==========================================
+ Coverage 86.66% 86.79% +0.13%
==========================================
Files 86 85 -1
Lines 8771 8777 +6
Branches 1105 1109 +4
==========================================
+ Hits 7601 7618 +17
+ Misses 1128 1117 -11
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Finally... have been waiting for a long time for this fix. Thanks @KhafraDev 👍🏻 |
This was merged under a minor release, but breaks the |
I was surprised it got merged so quickly, I even put that it was likely a breaking change. The real fix is probably waiting for nodejs/node#44731 however. |
After revisiting internally, we will likely not revert and monitor the repository for bugs caused by this. The chance of it being faulty is very unlikely. Overall the aforementioned pattern is questionable as a recommendation with the slightest consideration of our general user base, as it will globally alter undici for any requests, not just discord.js specific ones. Fixing the issue currently at hand also has priority at this moment in time - again, actively watching for bugs/breaking reports for the time being. |
Please describe the changes this PR makes and why it should be merged:
Fixes #8629
Fixes #8489
Repeated issue:
I have no way of testing this but 30 seconds seems to work for others.
The issue seems to be with misconfigured ipv6, see nodejs/undici#1531 (comment)
Status and versioning classification: