Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApplicationCommand): incorrect comparison in equals method #10497

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix(ApplicationCommand): incorrect comparison in equals method #10497

merged 1 commit into from
Sep 11, 2024

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Sep 11, 2024

Please describe the changes this PR makes and why it should be merged:
Raised in support: https://discord.com/channels/222078108977594368/824411059443204127/1283275617667780628

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@monbrey monbrey requested a review from a team as a code owner September 11, 2024 05:30
@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:30am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:30am

@Jiralite Jiralite added this to the discord.js 14.16.2 milestone Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 3c74aa2 into discordjs:main Sep 11, 2024
6 checks passed
@whizbangpop whizbangpop mentioned this pull request Oct 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Oct 3, 2024
Open
@JajoScript JajoScript mentioned this pull request Oct 4, 2024
Merged
@HowlingArcher HowlingArcher mentioned this pull request Oct 4, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 4, 2024
Open
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
@monbrey @nyapat
fix(ApplicationCommand): incorrect comparison in equals method (disco…
f47bdd9 
…rdjs#10497)
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
@Azzraya Azzraya mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 13, 2024
Open
Open
@NotYourAverageGamer NotYourAverageGamer mentioned this pull request Oct 21, 2024
Merged
@mezotv mezotv mentioned this pull request Oct 23, 2024
Closed
@jshuntley jshuntley mentioned this pull request Oct 24, 2024
Open
@VicDario VicDario mentioned this pull request Oct 25, 2024
Merged
@HowlingArcher HowlingArcher mentioned this pull request Oct 25, 2024
Open
@lkeff lkeff mentioned this pull request Oct 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 27, 2024
Open
@JajoScript JajoScript mentioned this pull request Oct 27, 2024
Merged
@whizbangpop whizbangpop mentioned this pull request Oct 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 28, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Nov 1, 2024
Open
@saiteja-madha saiteja-madha mentioned this pull request Nov 2, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Nov 3, 2024
Open
@Adidi1234 Adidi1234 mentioned this pull request Nov 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Nov 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 5, 2024
Open
@ClearlyElevated ClearlyElevated mentioned this pull request Nov 6, 2024
Open
@jakejack13 jakejack13 mentioned this pull request Nov 7, 2024
Merged
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Nov 10, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Nov 10, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.16.2
Development

Successfully merging this pull request may close these issues.
4 participants
@monbrey @vladfrangu @SpaceEEC @Jiralite