Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VoiceState): add methods for fetching voice state #10442

Merged
merged 13 commits into from
Aug 20, 2024
Merged

feat(VoiceState): add methods for fetching voice state #10442

merged 13 commits into from
Aug 20, 2024

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Aug 12, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Depends on

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@imnaiyar imnaiyar requested a review from a team as a code owner August 12, 2024 16:08
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 9:56am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 9:56am

sdanialraza
sdanialraza reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sdanialraza sdanialraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GatewayVoiceState is now unused and can be removed from here

Syjalo
Syjalo suggested changes Aug 12, 2024
View reviewed changes
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/managers/VoiceStateManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/VoiceStateManager.js Outdated Show resolved Hide resolved
packages/core/src/api/voice.ts Outdated Show resolved Hide resolved
packages/core/src/api/guild.ts Outdated Show resolved Hide resolved
@jaw0r3k
Copy link
Contributor

jaw0r3k commented Aug 12, 2024

You forgot to handle @me as a user parameter (docs reference)

Qjuh
Qjuh suggested changes Aug 13, 2024
View reviewed changes
packages/core/src/api/guild.ts Outdated Show resolved Hide resolved
@imnaiyar imnaiyar mentioned this pull request Aug 19, 2024
Merged
almeidx
almeidx approved these changes Aug 20, 2024
View reviewed changes
packages/core/src/api/guild.ts Show resolved Hide resolved
@almeidx almeidx removed the blocked label Aug 20, 2024
@Azzraya Azzraya mentioned this pull request Sep 28, 2024
Open
@ReiseArnor ReiseArnor mentioned this pull request Sep 29, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 30, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Oct 3, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 4, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 4, 2024
Open
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
@imnaiyar @almeidx
@kodiakhq @nyapat
feat(VoiceState): add methods for fetching voice state (discordjs#10442)
a8097ab 
* feat(VoiceState): add methods for fetching voice state

* fix: links to new methods

* chore: remove unused import

* chore: use member id

* chore: requested changes

* chore: '@me' as fetch param

* chore: add ediUserVoiceState return type

* refactor: redirect function calls to VoiceAPI

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
@Azzraya Azzraya mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 13, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Oct 24, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 25, 2024
Open
@lkeff lkeff mentioned this pull request Oct 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 27, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 28, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Nov 1, 2024
Open
@saiteja-madha saiteja-madha mentioned this pull request Nov 2, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Nov 3, 2024
Open
@Adidi1234 Adidi1234 mentioned this pull request Nov 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Nov 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 5, 2024
Open
@ClearlyElevated ClearlyElevated mentioned this pull request Nov 6, 2024
Open
@jakejack13 jakejack13 mentioned this pull request Nov 7, 2024
Merged
@AlexEKinney AlexEKinney mentioned this pull request Nov 10, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Nov 10, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdanialraza sdanialraza sdanialraza left review comments

@Syjalo Syjalo Syjalo requested changes

@Qjuh Qjuh Qjuh approved these changes

@almeidx almeidx almeidx approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:core packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@imnaiyar @jaw0r3k @vladfrangu @kyranet @SpaceEEC @almeidx @Syjalo @Qjuh @sdanialraza