You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A lot of times we aren’t always immediately aware of the certain impacts some commits have on performance. We should have a performance suite that can be manually triggered on pull requests via a bot.
Ideal solution or implementation
Taking inspirations from the typescript GitHub repo, we would create a bot that can run various sets of performance suites. This bot would be able to be triggered by anyone in the djs team. Once testing finishes the bot will comment on the PR letting us know the quantitative performance difference
Alternative solutions or implementations
Use a GitHub action, but this is much less flexible since you can’t pick specific suites, and it’s somewhat unneeded in PR’s that don’t effect performance like typings PR’s.
Feature
A lot of times we aren’t always immediately aware of the certain impacts some commits have on performance. We should have a performance suite that can be manually triggered on pull requests via a bot.
Ideal solution or implementation
Taking inspirations from the typescript GitHub repo, we would create a bot that can run various sets of performance suites. This bot would be able to be triggered by anyone in the djs team. Once testing finishes the bot will comment on the PR letting us know the quantitative performance difference
Alternative solutions or implementations
Use a GitHub action, but this is much less flexible since you can’t pick specific suites, and it’s somewhat unneeded in PR’s that don’t effect performance like typings PR’s.
Other context
An example of this in the typescript repo:
microsoft/TypeScript#47109 (comment)
The text was updated successfully, but these errors were encountered: