Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub bot for performance regression/progression testing #7098

Open
suneettipirneni opened this issue Dec 11, 2021 · 0 comments
Open

Add GitHub bot for performance regression/progression testing #7098

suneettipirneni opened this issue Dec 11, 2021 · 0 comments

Comments

@suneettipirneni
Copy link
Member

suneettipirneni commented Dec 11, 2021

Feature

A lot of times we aren’t always immediately aware of the certain impacts some commits have on performance. We should have a performance suite that can be manually triggered on pull requests via a bot.

Ideal solution or implementation

Taking inspirations from the typescript GitHub repo, we would create a bot that can run various sets of performance suites. This bot would be able to be triggered by anyone in the djs team. Once testing finishes the bot will comment on the PR letting us know the quantitative performance difference

Alternative solutions or implementations

Use a GitHub action, but this is much less flexible since you can’t pick specific suites, and it’s somewhat unneeded in PR’s that don’t effect performance like typings PR’s.

Other context

An example of this in the typescript repo:

microsoft/TypeScript#47109 (comment)

@suneettipirneni suneettipirneni changed the title Add GitHub bot for performance testing Add GitHub bot for performance regression/progression testing Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants