-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Message): make #channel and #guild getters #6271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almostSouji
force-pushed
the
msg-ch-getter
branch
from
August 2, 2021 10:11
af3ad87
to
7661691
Compare
almostSouji
changed the title
fix(Message): make #channel a getter
fix(Message): make #channel and #guild getters
Aug 2, 2021
almostSouji
force-pushed
the
msg-ch-getter
branch
from
August 2, 2021 10:14
7661691
to
63a9f41
Compare
kyranet
requested changes
Aug 2, 2021
NotSugden
reviewed
Aug 3, 2021
This needs a rebase. |
almostSouji
force-pushed
the
msg-ch-getter
branch
from
August 3, 2021 22:28
3434c6f
to
c306e89
Compare
kyranet
approved these changes
Aug 3, 2021
vladfrangu
approved these changes
Aug 3, 2021
SpaceEEC
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
While the direct issue outlined in #6168 has been fixed in #6263, the same issue (
Message#channel
returning a text channel) still persists for old messages sent in this same channel before it was converted. As outlined in the issue the least intrusive way to fix this I could think of is makingMessage#channel
a getter to retrieve the channel from cache on demand. I use the Client cache (versus the guild cache) to be robust against DMs, if that has any caveats I did not think of, please let me knowMessage#channel
a getterMessage#guild
getter (relied onMessage#channel
before)MessageManager#_add
callMessage#channelId
whenever possible in other structuresMessage#channel#guild
toMessage#guild
DO NOT UNCACHE CHANNELS IF YOU NEED THEM TO DO THINGS
Status and versioning classification: