-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Managers): add customizable caching for managers #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
requested changes
Jul 3, 2021
kyranet
previously requested changes
Jul 3, 2021
SpaceEEC
previously requested changes
Jul 3, 2021
vladfrangu
previously requested changes
Jul 3, 2021
This needs a rebase. |
This needs a rebase. |
iCrawl
approved these changes
Jul 3, 2021
kyranet
approved these changes
Jul 3, 2021
SpaceEEC
approved these changes
Jul 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth a consideration to make LimitedCollection
public again, otherwise you'd have to reimplement it yourself if cacheWithLimits
doesn't cut it for somereason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
All managers are actually managers now:
BaseManager :> DataManager :> CachedManager
.BaseManager
has no cache,DataManager
has a cache getter and the resolve methods,CachedManager
is the whole thing.Customizable cache types for
CachedManager
s:Collection
interface can be used.Breaking changes in summary:
ReactionUserManager
's constructor, cus it was weird.Constants
intoOptions
.messageCacheMaxSize
.Things I wanna do but too much work/infeasible with current designs:
add
to something better, how aboutaddToCache
? Someone do this please.Status and versioning classification: