Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ThreadManager): fixed wrong private and fetchAll check #6012

Merged
merged 1 commit into from
Jul 3, 2021
Merged

fix(ThreadManager): fixed wrong private and fetchAll check #6012

merged 1 commit into from
Jul 3, 2021

Conversation

herrtxbias
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR fixes the fetchAll check for private Threads in ThreadManager#fetchArchived.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@kyranet kyranet added this to the Version 13 milestone Jul 2, 2021
@iCrawl iCrawl merged commit e4be666 into discordjs:master Jul 3, 2021
@herrtxbias herrtxbias deleted the fix-threads-fetch branch July 3, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckohen ckohen ckohen approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
4 participants
@herrtxbias @ckohen @iCrawl @kyranet