fix(Webhook): return void from #delete for consistency. #5954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Jun 28, 2021
iCrawl
approved these changes
Jun 29, 2021
iCrawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The typings for Webhook#delete says it returns
Promise<void>but it really returnsPromise<Buffer>with the buffer being an empty buffer because as https://discord.com/developers/docs/resources/webhook#delete-webhook states the route returns a 204 with no content. Webhook#deleteMessage has the same result from the route so to keep it consistent with that method and the typings this PR removes the return from the delete method.Status and versioning classification: