-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StageChannel): add createStageInstance method & use better naming convention #5951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with the breaking change as the object still has a required property (topic
).
If it's because StageChannel#createStageInstance
(probably should be createInstance
), you can do create({ ...options, channel: this.id })
.
It will be the same situation like
|
Co-authored-by: SpaceEEC <[email protected]>
Refactored some stuff to reflect the new naming convention for things related to stage instances. Added more information covering this change in the description above and changed the title. "instance of stage channel" What was I thinking pepehands |
Please describe the changes this PR makes and why it should be merged:
This PR adds a new
createStageInstance
method onStageChannel
that lets the user create a stage instance associated to it. It also refactors the options typedef to keep it consistent with rest of the lib:CreateStageInstanceOptions
is nowStageInstanceCreateOptions
channel
field is a seperate param now instead of being inside the options objectStatus and versioning classification: