Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MessageComponents): clickybois (MessageButton, MessageActionRow, associated Collectors) #5674

Merged
merged 55 commits into from
Jun 4, 2021
Merged

feat(MessageComponents): clickybois (MessageButton, MessageActionRow, associated Collectors) #5674

merged 55 commits into from
Jun 4, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented May 25, 2021 •
edited
Loading

No longer with the broken rebasing I accidentally introduced in #5656

For anyone curious, buttons look like this:

image

This includes:

  • New MESSAGE_COMPONENT Interaction type ComponentInteraction
  • A base MessageComponent class
  • New MessageActionRow component class
  • New MessageButton component class
  • ComponentInteractionCollector class and associated Message methods

I've so far modelled the components similarly to MessageEmbed
MessageButton is a builder class and MessageActionRow has methods similar in design to MessageEmbed#addFields for adding MessageButtons and any other future components they can hold.
Similarly, it should be possible to use raw object formats in the Message payload in the same way embeds can be included.

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I pretend to know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

@monbrey monbrey mentioned this pull request May 25, 2021
Closed
@stijnvdkolk
Copy link

stijnvdkolk commented May 26, 2021 •
edited
Loading

Components are only available in specific guilds - you will not be able to use these new methods yet.

They are released now.

@castdrian castdrian mentioned this pull request May 26, 2021
Merged
SpaceEEC
SpaceEEC requested changes May 26, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
src/structures/BaseMessageComponent.js Outdated Show resolved Hide resolved
src/structures/BaseMessageComponent.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Show resolved Hide resolved
typings/index.d.ts Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
SpaceEEC
SpaceEEC requested changes May 26, 2021
View reviewed changes
src/structures/ComponentInteraction.js Outdated Show resolved Hide resolved
SpaceEEC
SpaceEEC requested changes May 26, 2021
View reviewed changes
typings/index.d.ts Show resolved Hide resolved
Vicente015
Vicente015 suggested changes May 26, 2021
View reviewed changes
src/structures/BaseMessageComponent.js Outdated Show resolved Hide resolved
src/structures/Interaction.js Outdated Show resolved Hide resolved
src/structures/Message.js Outdated Show resolved Hide resolved
src/structures/MessageButton.js Outdated Show resolved Hide resolved
@monbrey
Copy link
Member Author

monbrey commented May 26, 2021

Draft PRs, by definition, are not ready for review.

Nobody should be using this, as the description clearly indicates.

@maybeanerd maybeanerd mentioned this pull request May 27, 2021
Closed
@iShibi iShibi mentioned this pull request May 27, 2021
Closed
@CodyJasonBennett CodyJasonBennett mentioned this pull request May 27, 2021
Closed
@monbrey monbrey force-pushed the message-components branch 2 times, most recently from 26e8c89 to e14477b Compare May 27, 2021 22:52
@monbrey monbrey marked this pull request as ready for review May 28, 2021 00:10
jaydns
jaydns suggested changes May 28, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
monbrey and others added 14 commits June 4, 2021 11:40
@monbrey
fix: align docs with typings, remove setType, add spliceComponents
6e691d4
@monbrey @SpaceEEC
fix: apply suggestions from code review
9876dec 
Co-authored-by: SpaceEEC <[email protected]>
@monbrey
fix: suggestions from code review
b14168e
@SpaceEEC @monbrey
fix: remove trailing whitespace
a31cea9
@SpaceEEC @monbrey
fix: remove max mention from addComponents too
77d3616
@monbrey @kyranet
types: apply suggestions from code review
784bffc 
Co-authored-by: Antonio Román <[email protected]>
@monbrey
fix: use const
d4ceeda
@monbrey
chore: remove unused props and constructor
de003f3
@monbrey
feat: enforce strings
234321d
@monbrey @vladfrangu
Update src/structures/Message.js
b152631 
Co-authored-by: Vlad Frangu <[email protected]>
@monbrey
docs: prop MessageButton#style is nullable
a281d79
@monbrey
feat: flatten to infinity
2d9fd1b
@monbrey @SpaceEEC
fix: apply suggestions from code review
961db5c 
Co-authored-by: SpaceEEC <[email protected]>
@monbrey @BannerBomb
fix: apply suggestions from code review
1a6a6c2 
Co-authored-by: BannerBomb <[email protected]>
@iCrawl iCrawl merged commit cbd7f2b into discordjs:master Jun 4, 2021
@ghost
Copy link

ghost commented Jun 4, 2021

Woohoo 🎉

@monbrey monbrey deleted the message-components branch June 4, 2021 21:29
@letterjm letterjm mentioned this pull request Jun 5, 2021
Closed
@cntkillme cntkillme mentioned this pull request Jun 5, 2021
Closed
@iShibi iShibi mentioned this pull request Jun 6, 2021
Merged
@jpdown jpdown mentioned this pull request Jun 6, 2021
Closed
@foxfriends foxfriends mentioned this pull request Jun 17, 2021
Open
@iCrawl iCrawl mentioned this pull request Jun 20, 2021
Closed
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@AverageHelper AverageHelper mentioned this pull request Jul 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckohen ckohen ckohen left review comments

@iShibi iShibi iShibi left review comments

@thewilloftheshadow thewilloftheshadow thewilloftheshadow left review comments

@NotSugden NotSugden NotSugden left review comments

@almostSouji almostSouji almostSouji left review comments

@jaydns jaydns jaydns requested changes

@Arechii Arechii Arechii left review comments

@BannerBomb BannerBomb BannerBomb left review comments

@Aqlow Aqlow Aqlow left review comments

@pablomayobre pablomayobre pablomayobre left review comments

@Vicente015 Vicente015 Vicente015 requested changes

@PyroTechniac PyroTechniac PyroTechniac requested changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@Darker-Ink Darker-Ink Darker-Ink approved these changes

@KuryKat KuryKat KuryKat approved these changes

@drillskibo drillskibo drillskibo approved these changes

@cosmicle0 cosmicle0 cosmicle0 approved these changes

@kakarot-dev kakarot-dev kakarot-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

Request for adding support for message components