Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Util): make cleanContent take a channel instead of a message #5535

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Apr 16, 2021

Please describe the changes this PR makes and why it should be merged:
Currently Util#cleanContent takes a Message object in addition to the string. All the info accessed from the Message object can also be accessed from the message's channel. This PR makes it take a channel instead.

This is beneficial because now Util#cleanContent can be used in other contexts, such as interactions.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@iCrawl iCrawl merged commit f1c0c04 into discordjs:master Apr 18, 2021
@advaith1 advaith1 deleted the cleancontent-channel branch April 19, 2021 23:16
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants