-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GuildChannel): make createOverwrite and updateOverwrite not dependent on cache #5489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typings need updating too
I'd just like to point out that this fixes 2 of 8 methods that have this issue, most of the other ones take a role which is more likely to be cached, but there are still edge cases. I really like the way this was handled, not sure if this PR would be a good place to make changes to the other methods as well. For reference, you can see these other methods in #5242 |
Co-authored-by: SpaceEEC <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change to make CI pass
Co-authored-by: Antonio Román <[email protected]>
Depends on what makes more sense to merge. Does a whole new manager really make sense here, except to abstract things more thoroughly? |
Co-authored-by: Antonio Román <[email protected]>
Please describe the changes this PR makes and why it should be merged:
The above two methods need
userOrRole
to be in cache, so that they can be resolved in order to get thetype
of overwrite. This in some edge cases where the provideduserOrRole
is id of an uncached structure will throw an error. This PR adds a new optional parametertype
for these two methods. Which can be used to manually set the type of the overwrite, making the methods not rely on the cache just to get thetype
.Status and versioning classification: