-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for fetching multiple guilds #5472
Conversation
Since |
Are there different properties in owner that are available to OAuth2's Guild but not in regular Guild? Is PartialGuild just a subset ot Guild? If the answers are However, if they differ, generalizing them might throw away some potentially useful data, so an extra structure would be preferred. |
OAuth2's guild has two additional properties (namely |
In that case, a separate structure would be preferred so this data is readily available. |
They could also be added to Another thing I considered is that if we decide to keep them separate, maybe |
I'd prefer If we want to abstract this we could go for a |
Done, however the guild constructor is really messy so I'm not sure if I broke anything there
|
This needs another rebase. |
Co-authored-by: SpaceEEC <[email protected]>
Please describe the changes this PR makes and why it should be merged:
This PR adds support for
GET /users/@me/guilds
. They have a weird set of properties, so I made a separate class for them.Status and versioning classification: