-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MessageEmbed): remove normalizeField validation #5459
Conversation
`normalizeField` was made with a custom error to throw, this PR removes that so that a proper API error with path will be thrown instead. This makes the error message more informative.
How is the location of where you are sending the message more informative than where you are adding the malformed field? |
We don't really check values in many other places, so why should we do so here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove those two constants, as their only references are removed with this PR:
Removes the constants for empty embed name/values.
Removed. |
Please describe the changes this PR makes and why it should be merged:
normalizeField
was made with a custom error to throw, this PR removes that so that a proper API error with path will be thrown instead. This makes the error message more informative.Status and versioning classification: