fix(Guild/GuildChannel): methods reason arg usage #5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehairy
approved these changes
Mar 22, 2021
SpaceEEC
approved these changes
Mar 28, 2021
iCrawl
approved these changes
Mar 28, 2021
iCrawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I fixed an issue where the following methods were passing the reason argument as a property to the edit method instead of a parameter.
Most of these methods have had it that way for 3 years in which I don't know if y'all will want to fix it at this point. But I brought it up in case.
Guild#setIcon-> was introduced in #1975 (3 years ago)Guild#setSplash-> was introduced in #1975 (3 years ago)Guild#setBanner-> was introduced in #3364 (2 years ago)Guild#setDiscoverySplash-> was introduced in #4619 (7 months ago)GuildChannel#overwritePermissions-> was introduced in #3853 (1 year ago)Status and versioning classification: