-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessageMentions#channels): Fix type of channels of mentions #5370
fix(MessageMentions#channels): Fix type of channels of mentions #5370
Conversation
Change type of channels mentions from TextChannel to GuildChannel.
Incorrect, since we parse channel mentions from content and resolve them based on the available cache it can be any channel type, including DMChannel, the only requirement is (meaning the docs and typings are wrong) |
Change type of channels mentions from GuildChannel to Channel.
When I verified it, it was exactly as you said. |
Docstring also needs updating |
Oops. Is it all right like this? |
Can you also update the types for the private properties? Line 1111 in 9581918
|
Thank you for telling me. |
Please describe the changes this PR makes and why it should be merged:
Change type of channels mentions from TextChannel to GuildChannel.
MessageMentions#channels
are defined asCollection<Snowflake, TextChannels>
even though they returnCollection<Snowflake, GuildChannels>
.Status and versioning classification: