Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildFeatures): added the new screening features #5328

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

PhaxeNor
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

This PR adds the typings for MEMBER_VERIFICATION_GATE_ENABLED and PREVIEW_ENABLED in GuildFeatures
Also added comments in Guilds.js for possible guild feature values.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@ckohen
Copy link
Member

ckohen commented Feb 14, 2021

This and more handled in #5144 which is on hold until membership screening is finalized in the API.

@advaith1
Copy link
Contributor

afaik the guild features aren't changing (they're still documented) so this should be fine for now

@kyranet kyranet requested a review from vladfrangu March 28, 2021 17:38
@ckohen
Copy link
Member

ckohen commented Mar 28, 2021

As tipakA pointed out in 5144, the rest of the features are alphabetically ordered.

@iCrawl iCrawl merged commit 3c175cb into discordjs:master Apr 15, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants