feat: PermissionOverwriteManager #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 18, 2020 12:39
Pull Changes
Pull changes
NotSugden
suggested changes
Feb 12, 2021
tguichaoua
suggested changes
Feb 12, 2021
vladfrangu
requested changes
Apr 30, 2021
vladfrangu
requested changes
May 11, 2021
vladfrangu
requested changes
May 11, 2021
kyranet
approved these changes
May 13, 2021
|
This needs another rebase. |
|
@iCrawl done |
|
This needs a rebase. |
|
@iCrawl done x2 |
|
You wouldn't get this from any other guy, but this needs another rebase 🎶 |
|
@vladfrangu done x3 |
SpaceEEC
previously requested changes
Jun 19, 2021
DraftProducts
approved these changes
Jun 25, 2021
SpaceEEC
requested changes
Jun 30, 2021
|
This needs a rebase + Space's requested changes addressed. |
SpaceEEC
approved these changes
Jul 3, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR introduces
PermissionOverwriteManager, to manage guild channel permission overwrites and store their cache. This was brought up as an approach to #5234 (comment). It also removes the existing permission overwrite methods fromGuildChannel, it is, therefore, semver major. Some of the logic isstolentaken from #5489 and merged here as well.Status and versioning classification: