feat(Message): add ReplyMessageOptions for #reply #5296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The
options
parameter forMessage#reply
has areplyTo
field. This field later gets set tothis
inside the method. This begs the question that why even expose thereplyTo
option to the end-user at all in this case. This PR creates a new typeReplyMessageOptions
that replacesMessageOptions
parameter forMessage#reply
method. This newtype
foroptions
has all the fields that are inMessageOptions
except thereplyTo
field.Docs show the default value for
repliedUser
inMessageMentionOptions
asnone
, butMessage#reply
does ping the author of the referenced message by default. The PR also fixes that.Status and versioning classification: