Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApiMessage): remove resolve() from typings #5241

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix(ApiMessage): remove resolve() from typings #5241

merged 1 commit into from
Jan 27, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Jan 22, 2021

Please describe the changes this PR makes and why it should be merged:

This PR removes resolve() and adds the isMessage in APIMessage's typings.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit a6bc39d into discordjs:master Jan 27, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@kyranet kyranet deleted the fix/remove-non-existing-method-from-typings branch July 5, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranet @iCrawl @SpaceEEC