Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GuildChannel): check for community required channels in GuildChannel#deletable #5170

Merged
merged 4 commits into from
Apr 14, 2021
Merged

fix(GuildChannel): check for community required channels in GuildChannel#deletable #5170

merged 4 commits into from
Apr 14, 2021

Conversation

xiBread
Copy link
Contributor

@xiBread xiBread commented Dec 31, 2020 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Currently, GuildChannel#deletable will return true regardless if the channel is required for a community (rules, public updates) and will throw a 50074: Cannot delete a channel required for Community guilds. This PR adds an inequality check between the GuildChannel#id and the Guild#rulesChannelID or Guild#publicUpdatesChannelID

--

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

NotSugden
NotSugden suggested changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@NotSugden NotSugden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style changes also needed

src/structures/GuildChannel.js Outdated Show resolved Hide resolved
Mesteery
Mesteery suggested changes Jan 6, 2021
View reviewed changes
src/structures/GuildChannel.js Outdated Show resolved Hide resolved
SpaceEEC
SpaceEEC requested changes Feb 16, 2021
View reviewed changes
src/structures/GuildChannel.js Outdated Show resolved Hide resolved
@xiBread @SpaceEEC
fix logic
62cb2c5 
Co-authored-by: SpaceEEC <[email protected]>
@kyranet kyranet requested a review from iCrawl April 14, 2021 19:52
@iCrawl iCrawl merged commit b710a43 into discordjs:master Apr 14, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden requested changes

@Mesteery Mesteery Mesteery requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
9 participants
@xiBread @vladfrangu @iCrawl @kyranet @SpaceEEC @NotSugden @Mesteery @almostSouji @notMorrow