fix(MessageEmbed): include `author.name` in length getter #5167

xiBread · 2020-12-31T04:12:34Z

Please describe the changes this PR makes and why it should be merged:
Fixes #5166

Status

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

This PR changes the library's interface (methods or parameters added)
- This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
This PR only includes non-code changes, like changes to documentation, README, etc.

src/structures/MessageEmbed.js

Co-authored-by: Papaia <[email protected]>

src/structures/MessageEmbed.js

fix(MessageEmbed): include author.name in length getter

49b9400

papaia reviewed Dec 31, 2020

View reviewed changes

src/structures/MessageEmbed.js Outdated Show resolved Hide resolved

papaia reviewed Dec 31, 2020

View reviewed changes

src/structures/MessageEmbed.js Outdated Show resolved Hide resolved

xiBread and others added 2 commits December 31, 2020 01:55

Update src/structures/MessageEmbed.js

65b7f7b

Co-authored-by: Papaia <[email protected]>

style: oxford comma

43c4fb0

Co-authored-by: Papaia <[email protected]>

kyranet added type: bugfix labels Dec 31, 2020

kyranet requested review from iCrawl, SpaceEEC and vladfrangu December 31, 2020 10:27

kyranet approved these changes Dec 31, 2020

View reviewed changes

SpaceEEC approved these changes Dec 31, 2020

View reviewed changes

vladfrangu approved these changes Dec 31, 2020

View reviewed changes

NotSugden suggested changes Dec 31, 2020

View reviewed changes

src/structures/MessageEmbed.js Show resolved Hide resolved

refactor: es2020 syntax

003d7e9

iCrawl approved these changes Dec 31, 2020

View reviewed changes

iCrawl merged commit e37160f into discordjs:master Dec 31, 2020

iCrawl added this to the Version 13 milestone Jun 27, 2021

Provide feedback