Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Message): added string type for message nonce #4782

Merged
merged 14 commits into from
Nov 22, 2020
Merged

feat(Message): added string type for message nonce #4782

merged 14 commits into from
Nov 22, 2020

Conversation

wonderlandpark
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

At Discord API document message nonce type is integer or string.
But, for discord.js only accept integer.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@wonderlandpark wonderlandpark changed the title Fixed Nonce type feat(Message): added string type for message nonce Sep 3, 2020
vladfrangu
vladfrangu requested changes Sep 3, 2020
View reviewed changes
src/errors/Messages.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
typings/index.d.ts Show resolved Hide resolved
NotSugden
NotSugden reviewed Sep 3, 2020
View reviewed changes
src/errors/Messages.js Outdated Show resolved Hide resolved
src/structures/APIMessage.js Outdated Show resolved Hide resolved
@wonderlandpark @NotSugden
fix: duped code
60c78fd 
Co-authored-by: Sugden <[email protected]>
SpaceEEC
SpaceEEC requested changes Sep 20, 2020
View reviewed changes
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/errors/Messages.js Outdated Show resolved Hide resolved
src/errors/Messages.js Outdated Show resolved Hide resolved
@kyranet kyranet requested a review from iCrawl September 22, 2020 07:43
SpaceEEC
SpaceEEC requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

src/errors/Messages.js Outdated Show resolved Hide resolved
@wonderlandpark
Copy link
Contributor Author

Hello, when will this merged? Is it for the next release?

@iCrawl iCrawl merged commit 4b555fd into discordjs:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wonderlandpark @vladfrangu @iCrawl @kyranet @SpaceEEC @NotSugden