Download pdf feature #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 15, 2019 09:24
This reverts commit 33bd74e.
pimotte
requested review from
bkaptijn,
DennisHouterman and
aozdmr
and removed request for
bkaptijn
DennisHouterman
approved these changes
May 16, 2019
|
As far as I know, https://www.npmjs.com/package/canvas2pdf is the only candidate to render a pdf from a canvas in a way that is not just embedding the picture. No project has a dependency on this module, which made me hesitant to use it. If tooltips are indeed a needed feature at some point, we can switch to this and see if it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is untested in the e2e test. This is due to the fact that we use a library to generate it, which means we can't really hook into the process in a solid way, and cypress not supporting this yet (see cypress-io/cypress#949)
Fixes #59