Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StampCreator into functions instead of a class of static functions. #714

Open
jeremykubica opened this issue Sep 19, 2024 · 0 comments · May be fixed by #761
Open

Make StampCreator into functions instead of a class of static functions. #714

jeremykubica opened this issue Sep 19, 2024 · 0 comments · May be fixed by #761

Comments

@jeremykubica
Copy link
Contributor

The StampCreator class in search/stamp_creator.cpp doesn't do anything that requires it to be a class and just adds overhead when we are using it from Python (creating an unneeded object). We should remove the class and just call the functions directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants