Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize filtering code #353

Closed
jeremykubica opened this issue Sep 28, 2023 · 1 comment
Closed

Optimize filtering code #353

jeremykubica opened this issue Sep 28, 2023 · 1 comment
Assignees
@maxwest-uw
Labels
good first issue

Comments

@jeremykubica
Copy link
Contributor

Move the current filtering code to C++ or use numba to optimize. Ideally this would take the form of a Filter class that can be overloaded by astronomers to produce their own filters. The filter code is currently called in run_search within run_search.py.

This writing new benchmarks to time the code and quantifying the changes.
@maxwest-uw maxwest-uw self-assigned this Oct 18, 2023
@maxwest-uw maxwest-uw mentioned this issue Nov 6, 2023
Merged
@jeremykubica
Copy link
Contributor Author

Completed in #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxwest-uw maxwest-uw

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremykubica @maxwest-uw