Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add merge included #485

Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat: Add merge included #485

merged 1 commit into from
Sep 5, 2024

Conversation

makamekm
Copy link
Contributor

No description provided.

@makamekm makamekm force-pushed the add-merge-included branch from 71f395f to b0231a1 Compare August 26, 2024 15:11
@makamekm makamekm changed the title feat: Add merge included WIP feat: Add merge included Aug 26, 2024
@@ -171,7 +171,7 @@ const index: MarkdownItPluginCb<Options> = (md, options) => {
}

md.renderer.rules.anchor_hidden_desc = function (tokens, index) {
return '<span class="visually-hidden" data-no-index="true">' + escapeHtml(tokens[index].content) + '</span>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем удаляешь полезное?

Copy link
Contributor Author

@makamekm makamekm Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я их не трогал, это merge с мастера. Еще перепройдусь по всему коду, вдруг мердж еще накосячил где

// The finction reads the files from bottom to top(!). It stops the loop if it does not have anything to swap.
// If the function finds something to process then it restarts the loop because the position of the last element has been moved.
// eslint-disable-next-line no-unmodified-loop-condition
while (input) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что-то как-то жестко.
Ты тут в цикле несколько раз разбиваешь файл на строки и склеиваешь обратно.

}

// Null protection for lint mode
if (md && root && path) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот эту нормализацию вынеси в самый старт препроцессора, зачем это постоянно нормализовывать?

@makamekm makamekm merged commit 0cf1e0e into master Sep 5, 2024
1 check passed
@makamekm makamekm deleted the add-merge-included branch September 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants