Use <details> tag for cuts #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace div tags to <details> and <summary> tags. Delete CSS selector for closed cuts state because there is no need to write 2 separate selectors for cuts state (open/closed) after using <details> tag. Add "list-style" and "::-webkit-details-marker" to delete default toggle marker. Add color for focus outline because <details> tag allows to use keyboard navigation for cuts.
Change tests due to replacing <div> tags to <details> and <summary> tags in cuts.
martyanovandrey
approved these changes
Aug 2, 2024
makamekm
pushed a commit
that referenced
this pull request
Aug 12, 2024
* refactor: use <details> tag for cuts Replace div tags to <details> and <summary> tags. Delete CSS selector for closed cuts state because there is no need to write 2 separate selectors for cuts state (open/closed) after using <details> tag. Add "list-style" and "::-webkit-details-marker" to delete default toggle marker. Add color for focus outline because <details> tag allows to use keyboard navigation for cuts. * test: change tests for cuts Change tests due to replacing <div> tags to <details> and <summary> tags in cuts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://github.com/orgs/diplodoc-platform/projects/2/views/1?pane=issue&itemId=55495840
Replace div tags to details and summary tags for cuts.
Before:
before.1.mov
After:
after.1.mov