fix(anchors): use entire heading text for auto named anchors #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-named anchors used only last _text_ token of heading. I fixed that, and now auto-naming is generated from contents of all _text_ tokens of heading. Also, it fixed some cases where inline markup got into auto-generated anchors and they became broken _Example markup_: `## _Lorem ~~ipsum **dolor** sit~~ amet_` __Before__: auto anchor is `#amet` __Now__: auto anchor is `#lorem-ipsum-dolor-sit-amet`
d3m1d0v
force-pushed
the
fix-anchor-autonaming
branch
from
9270bfc to
84ffa59
Compare
3y3
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-named anchors used only last text token of heading. I fixed that, and now auto-naming is generated from contents of all text tokens of heading.
Also, it fixed some cases where inline markup got into auto-generated anchors and they became broken
Example markup:
## _Lorem ~~ipsum **dolor** sit~~ amet_Before: auto anchor is
#ametNow: auto anchor is
#lorem-ipsum-dolor-sit-amet