Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ergänze honorificPrefix als Feld für akademische Grade. #123

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Ergänze honorificPrefix als Feld für akademische Grade. #123

merged 3 commits into from
Jan 28, 2022

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jan 19, 2022 •
edited by acka47
Loading

Resolves #122

@kulla
Copy link
Contributor

kulla commented Jan 21, 2022

Da honorificPrefix ein string ist, würde ich den Satz

Akademische Titel sollen separate als `honorificPrefix` angegeben werden.

ändern zu

Der Akademische Titel SOLL separat als `honorificPrefix` angegeben werden.

(Wenn ich https://www.rfc-editor.org/rfc/rfc2119 richtig interpretiere, bedeutet SOLL, dass hier honorificPrefix optional ist)

@TobiasNx TobiasNx requested a review from acka47 January 26, 2022 09:27
@acka47 acka47 marked this pull request as ready for review January 27, 2022 09:55
acka47
acka47 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe zwei Dinge angepasst:

  • "Akademischer Grad" anstatt "Akademischer Titel", analog zu Wikipedia
  • KANN anstatt SOLL, um das optionale klarer zu machen, weil ja auch nicht jede Person einen Titel hat. (SOLL empfiehlt die Ergänzung, MAY/KANN macht klar, dass es Fälle gibt, in denen eine Vergabe nicht sinnvoll ist.)
    +1

@acka47 acka47 requested a review from kulla January 27, 2022 09:59
@acka47 acka47 assigned kulla and unassigned acka47 Jan 27, 2022
@kulla kulla merged commit 23a2a61 into main Jan 28, 2022
@kulla kulla deleted the 122-honorificPrefix branch January 28, 2022 11:10
@acka47 acka47 mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulla kulla kulla approved these changes

@acka47 acka47 acka47 approved these changes

Assignees

@kulla kulla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

honorificPrefix
3 participants
@TobiasNx @kulla @acka47