ensure multiple markdown tables are rendered #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seeks to fix issue #61 by printing all output to the `io.Writer` passed to `writer.TableWriter#Write`. This ensures multiple, distinct markdown tables are printed, even when `tf-summarize` is invoked with both `-md` and `-out` flags. Previously, `fmt.Println()` was used to separate the markdown tables, but this is insufficient when `-out` is used with a non-STDOUT writer, as is the case when writing output to a `-out`-specified file.
dineshba
approved these changes
Jan 8, 2024
|
@dineshba Thanks for the feedback and approval! Do you have any sense of when this PR will be merged & released? |
|
Away from laptop till weekend. I'll release it by this weekend... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to fix issue #61 by printing all output to the
io.Writerpassed towriter.TableWriter#Write. This ensures multiple, distinct markdown tables are printed, even whentf-summarizeis invoked with both-mdand-outflags.Previously,
fmt.Println()was used to separate the markdown tables, but this is insufficient when-outis used with a non-STDOUT writer, as is the case when writing output to a-out-specified file.