GUIDELINES.md

Coding Guidelines

Do not code like they used to code in 1990's. Code with The next generation JavaScript

There are lot of general guidelines. Here's few that I insist.

• Write clean(Prettier will take care of this) and DRY(Don’t Repeat Yourself) code.

• Avoid mutating variables. Could use ImmutableJs if you like.

• Never use var. Use const

• Always use arrow functions(better binding of this)

• Use spread to concat arrays or objects

  const a = { a: 1, b: 2 },
    c = { b: 0, c: 3 };
  const d = { ...a, ...c };

• Do not have more than 100 lines in a file. Break it up into multiple files.

• Do not use a, x or temp for variable/function names. The variable name itself should define what it does.

  // Dirty
  const done = false;
  const complete = false;
  // Clean
  const isComplete = false;
  
  // Dirty
  const fetchUser = () =>
    fetch(uri) // Get from REST API
      .then(convertFormat) // Convert to snakeCase
      .then(validate); // Make sure the the user is valid
  // Clean
  const fetchUser = () =>
    fetch(uri) // Get from REST API
      .then(snakeToCamelCase) // Convert to snakeCase
      .then(validateUser); // Make sure the the user is valid

• Use lodash for larger/nested array/object or complex calculations.

• Use camel case for variables, functions & for almost everything

  const first_name = 'Radik'; // wrong
  const name = {
    'first-name': 'Radik', // wrong
    firstName: 'Radik', // correct
  };
  const firstName = 'Radik'; // correct

• Avoid passing new closures to subcomponents

  <input
    type="text"
    value={model.name}
    // onChange={(e) => { model.name = e.target.value }}
    // ^ Not this. Use the below
    onChange={this.handleChange}
    placeholder="Your Name"
  />
  

Git Guidelines

General

• Never ever push to master branch(I'll kill u if u do so in my repo)
• Always work in a separate branch
• Rebase branch before raising a PR(Pull/Merge Request)
• Make sure to run tests(yarn run test) & validations(yarn run validate) before committing the changes.

Branch naming conventions

• Use underscore to join words
• Use grouping words at the beginning of your branch name

  #Dirty
  login_logout
  #Clean
  auth/login
  auth/logout
  #So you can group another branch like
  auth/forgot_password

Commit messages

• Don't end commit message with a period(.)
• Add frequent commit messages

  #Dirty
  login and logout
  #Clean
  #Make separate commits for login and logout features
  login
  logout

• Provide descriptive commit messages

  #Dirty
  login page bug fix
  #Clean
  Fix login form UI bug
  - username label fix indentation
  - password icon increase size

• Begin commit message with Add, Fix, Enhance, Increase, Reduce words to be more specific on type of action you did

  Add login feature
  Remove forgot password feature
  Enhance logout page UI
  - Add logout icon
  - Reduce logout button size