[v0.16] Fix NLL compatibility #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mark-Simulacrum Thank you for this PR! I've created a |
|
Ah, I think I forgot to drop that, it's not strictly necessary, I can drop it if you'd like. |
That would be great! |
|
Okay, I've dropped the deprecation commit, so this should be good to go. (Closed and reopened because CI failed due to seemingly unrelated -- perhaps network -- reasons). |
|
Thanks! Don't mind the CI. It will fail because of a changes on travis ubuntu version. We fixed our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncovered by a crater run in rust-lang/rust#63565, the most recent v0.16.x version breaks when NLL is fully enabled. This PR is targeted to be based atop tag v0.16.13 (it's probably easiest to merge it manually, unless you want to create a branch for this PR to target).