fix: memoize cache maybe null && open tab twice

DimensionDev · Dec 2, 2019 · 88e54b6 · 88e54b6
1 parent e17d92c
commit 88e54b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/social-network-provider/facebook.com/Worker/fetchPostContent.ts b/src/social-network-provider/facebook.com/Worker/fetchPostContent.ts
@@ -35,10 +35,11 @@ export async function fetchPostContentFacebook(post: PostIdentifier<PersonIdenti
                 }
             } catch (e) {
                 console.warn(e)
-                memoizeFetch.cache.delete(url)
+                memoizeFetch.cache?.delete(url)
             }
         }
     }
+
     // Path 2: fetch by tab task
     return tasks(getPostUrlAtFacebook(post, 'open')).getPostContent()
 }
diff --git a/src/social-network-provider/facebook.com/Worker/fetchProfile.ts b/src/social-network-provider/facebook.com/Worker/fetchProfile.ts
@@ -34,14 +34,9 @@ export async function fetchProfileFacebook(who: PersonIdentifier): Promise<Profi
                 return { bioContent: bio }
             } catch (e) {
                 console.warn(e)
-                memoizeFetch.cache.delete(url)
+                memoizeFetch.cache?.delete(url)
             }
         }
-    } else {
-        // Open a new tab in the background
-        tasks(getProfilePageUrlAtFacebook(who, 'open'), {
-            runAtTabID: activeTabID,
-        }).getProfile(who)
     }
 
     // Path 2: fetch by tab task