fix: infinite recreate due to wrong dep of useEffect

DimensionDev · Nov 11, 2019 · 457eee9 · 457eee9
1 parent 7cd669f
commit 457eee9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/extension/options-page/Backup.tsx b/src/extension/options-page/Backup.tsx
@@ -72,7 +72,9 @@ export default function BackupDialog() {
                 setBackupObj(null)
                 setQRText('')
             })
-    }, [currentIdentifier, identity])
+        // eslint will insert currentIdentifier to deps, which causes loop
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [identity])
 
     const downloadAsFile = () => {
         Services.Welcome.downloadBackup(backupObj)