Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polkit keyfile backend #9

Open
dilyn-corner opened this issue Oct 15, 2020 · 0 comments
Open

Fix polkit keyfile backend #9

dilyn-corner opened this issue Oct 15, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@dilyn-corner
Copy link
Owner

Thanks to the work done by solus, we have the ability to no longer require an entire javascript engine for a simple permissions framework. This is excellent, because it allows us to no longer require mozjs. Unfortunately, from everything I know of C, the code used for this keyfile backend is gross and bad. Ideally, we would simply clean it up. But I do not have the requisite knowledge of C to implement this (I don't even know enough to be dangerous).
As it stands, we need a single ifdef to remove the innetgr requirement imposed by this line. Assuming we can resolve this, we can drop the (very bad, from what I can gather) patch to musl.

If anybody can fix this small problem (or ideally, rewrite the entire policy backend solus is using), that would be a fantastic contribution to the project. In the mean time, I will be learning C.

@dilyn-corner dilyn-corner added the good first issue Good for newcomers label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant