Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one more node global #49

Open
pnlp-dev opened this issue Jul 19, 2020 · 1 comment
Open

Remove one more node global #49

pnlp-dev opened this issue Jul 19, 2020 · 1 comment

Comments

@pnlp-dev
Copy link

this.parser = parser(global, {

Looks like you removed node globals somewhat recently, but you missed one. This global reference is breaking in the latest version of Angular.

@AGFlash
Copy link

AGFlash commented Nov 27, 2020

Yup. Me to. As a workaround I dropped global from the call in decoder.js and just pass a zero:
58 this.parser = parser(0, {
... then in decoder.asm.js I switched back to the native functions
8 var heap = new Uint8Array(buffer) //use native Uint8Array instead of stdlib.Uint8Array
50 var pow = Math.pow //use native Math.pow instead of stdlib.Math.pow

Not 100% sure this will continue to work as intended (please advise) but at least it doesn't fall over any more and seems to do something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants