Interested in pull request to v3 ?

[jayprakashji]

Hi,

on a fork I updated your work to omnipay v3, and added some features and how-to doc block.
But there could be breaking changes, if you are using your version some way.

https://github.com/jayprakashji/omnipay-stripe-checkout/tree/v3

Currently I changed package name, that I dont have conflicts.

If you want PR, then I'll change it back, and we can work on the merge.

If you dont want the PR, that you dont break your app, then I will change also Namespace and release it by my package name.

[pedanticantic]

Hi @jayprakashji , I'm so sorry it's taken so long to reply to you.

Thank you for taking the trouble to make those fixes/changes/etc.

Unfortunately our system must use v2 of omnipay, so this repo must use v2. Our system uses something like 40 omnipay payment gateways (yes, really!) and it will be extremely difficult to upgrade.

If you can make a PR without the namespace change and without the upgrade to v3, I'll be happy to merge it in. I've had a quick look and I can't see any problems. Except one... your correction to one of my mistakes was incorrect(!) The word should be "transaction", not "translation".

If you want to do a v3 version, we can create a "version 2" branch and do v2 releases from there, and v3 releases from master (I'll merge your "v3" PR into the latter). I believe the SagePay repo does this. To be perfectly honest, I don't know how v3 differs from v2! Then any changes to one branch can be ported to the other, where sensible.

Cheers,
- Glenn -