967: Deactivate regions application process #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from application process, extend database schema for region by activatedForApplication, restructered "region verwalten", filter region options in dropdown for application process
f1sh1918
force-pushed
the
967-Deactivate-regions-application-process
branch
from
a2398cf to
8f372a2
Compare
administration/src/bp-modules/regions/ActivatedForApplicationCard.tsx
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/regions/ActivatedForApplicationCard.tsx
Outdated
Show resolved
Hide resolved
…ard.tsx Co-authored-by: Michael Markl <[email protected]>
Co-authored-by: Michael Markl <[email protected]>
Co-authored-by: Michael Markl <[email protected]>
…ard.tsx Co-authored-by: Michael Markl <[email protected]>
…ion is submitted to an inactive region
Nice catch so if an application process was started (and region was alreaday selected)nand in the meantime the region was deactivated it wasn't catched. |
sarahsporck
reviewed
May 23, 2023
administration/src/bp-modules/regions/ActivatedForApplicationCard.tsx
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/regions/ActivatedForApplicationCard.tsx
Outdated
Show resolved
Hide resolved
...tlin/app/ehrenamtskarte/backend/migration/migrations/V0005_AddRegionApplicationActivation.kt
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/Schema.kt
Show resolved
Hide resolved
administration/src/bp-modules/regions/data-privacy-policy/DataPrivacyOverview.tsx
Show resolved
Hide resolved
…ard.tsx Co-authored-by: Sarah <[email protected]>
…on-process' into 967-Deactivate-regions-application-process # Conflicts: # administration/src/bp-modules/regions/ActivatedForApplicationCard.tsx
sarahsporck
approved these changes
May 23, 2023
administration/src/bp-modules/regions/data-privacy-policy/DataPrivacyOverview.tsx
Outdated
Show resolved
Hide resolved
…PrivacyOverview.tsx Co-authored-by: Sarah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #967
Note: I had to restructure "region verwalten" a little bit
Maybe you can find some better texts for labels