604: Withdraw application #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view for user application view
…ication in internal application list
michael-markl
requested changes
Mar 15, 2023
administration/src/components/applications/ApplicationsOverview.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationsOverview.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationsOverview.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationUserOverviewController.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationUserOverviewController.tsx
Outdated
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/application/database/repos/ApplicationRepository.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/application/database/repos/ApplicationRepository.kt
Show resolved
Hide resolved
|
We should also be careful when deploying this change: We should probably delete the applications table before deploying, to make sure the new column will be there... Again, having proper DB migrations would be nice already, but I guess we're not there yet :D |
… add responsiveness, add check if application was already withdrawed
# Conflicts: # administration/src/Router.tsx # administration/src/graphql/applications/getApplication.graphql # backend/src/main/kotlin/app/ehrenamtskarte/backend/application/database/repos/ApplicationRepository.kt # backend/src/main/kotlin/app/ehrenamtskarte/backend/application/webservice/EakApplicationMutationService.kt # backend/src/main/kotlin/app/ehrenamtskarte/backend/application/webservice/EakApplicationQueryService.kt # specs/backend-api.graphql
michael-markl
approved these changes
Mar 16, 2023
administration/src/components/applications/VerificationsView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationsOverview.tsx
Outdated
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/application/database/repos/ApplicationRepository.kt
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantView.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationsOverview.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…tView.tsx Co-authored-by: Michael Markl <[email protected]>
…licant fkt, add withdraw date for internal application check, added callout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing: If we need sth like a "BearbeitungsId" should we use regionId-applicationId or any other suggestions
TODO: Check in Verification (Sarahs pr) view if application was withdrawed (separate task)
How to test: http://localhost:3000/antrag-einsehen/accessKey
resolves #604