826: Modify index on email to be lowercased #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsporck
force-pushed
the
826-emails-should-not-be-case-sensitive-when-logging-in
branch
from
43eb3c0 to
4680b31
Compare
michael-markl
approved these changes
Mar 2, 2023
|
|
||
| object Administrators : IntIdTable() { | ||
| val email = varchar("email", 100).uniqueIndex() | ||
| val email = varchar("email", 100) |
There was a problem hiding this comment.
Hmm.... In the optimal scenario, we would probably also remove the index that was previously created?
There was a problem hiding this comment.
Also according to stackoverflow we should up our limit from 100 to at least 254... (a different task for sure)
I feel like we are slowly getting into migrations territory :D ... We should probably think about some proper way to do DB migrations in general in the future...
sarahsporck
deleted the
826-emails-should-not-be-case-sensitive-when-logging-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression indices are not yet supported in exposed therefore the manual creation. If you have any idea where to create the index or whether there might be a better solution let me no.