Upgrade react-router-dom #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
requested review from
maxammann and
steffenkleinle
as code owners
michael-markl
force-pushed
the
upgrade-router
branch
from
1ed1e2b to
970238c
Compare
michael-markl
force-pushed
the
upgrade-npm-packages
branch
from
dc7bdbf to
dc541b6
Compare
michael-markl
force-pushed
the
upgrade-router
branch
from
970238c to
2cbe616
Compare
maxammann
approved these changes
Feb 23, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, we can finally (? :D) upgrade to a recent version of react-router-dom. The problem was that the usePrompt hook (as well as other parts of the API) was removed in a intermediate version of react-router-dom v6. With remix-run/react-router#8139 (comment) the feature was added back in a recent version.