-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
655: replace qr_code_scanner with mobile_scanner #679
655: replace qr_code_scanner with mobile_scanner #679
Conversation
@maxammann as you wished :) |
3a19a8d
to
95b153c
Compare
95b153c
to
77ff0f6
Compare
49261f9
to
521e895
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing now on iOS and Android
And I suspect this does not compile on iOS right now, because it is stuck in the check job |
… but the app does not crash)
Tested on iOS (release and debug) |
I also fixed linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Only code review)
for me it works without problems. And it seems it will take a little bit until integration, therefore I'd keep the solution as it is. Tested on Android again. Works fine. |
No need for that if it works on Android without that crash merge :) |
No description provided.