Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build configs to frontend #551

Merged
merged 44 commits into from
Sep 19, 2022
Merged

Add build configs to frontend #551

merged 44 commits into from
Sep 19, 2022

Conversation

maxammann
Copy link
Member

No description provided.

@maxammann maxammann changed the base branch from main to whitelabel September 14, 2022 12:43
@michael-markl michael-markl marked this pull request as ready for review September 19, 2022 13:43
.circleci/config.yml Show resolved Hide resolved
frontend/android/app/buildConfigs.gradle Show resolved Hide resolved
Comment on lines -1 to -5
#!/bin/bash

cp ../specs/backend-api.graphql schema.graphql
fvm flutter pub run build_runner build --delete-conflicting-outputs
rm schema.graphql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the replacement for this?

Comment on lines +7 to +12
if (buildConfig.featureFlags.developerFriendly) {
debugPrint("No developers were harmed while developing this app.");
} else {
debugPrint("Developers were harmed while developing this app.");
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this :D

Comment on lines +6 to +9
export type FeatureFlagsType = {
// Enables additional debugging output for devs (i18n, redux, hidden cities, version).
developerFriendly: boolean
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we use this ?

frontend/pubs/df_build_config/lib/builder.dart Outdated Show resolved Hide resolved
frontend/pubs/df_build_config/lib/builder.dart Outdated Show resolved Hide resolved
frontend/pubs/df_build_config/test/generate_test.dart Outdated Show resolved Hide resolved
.idea/runConfigurations/Format.xml Outdated Show resolved Hide resolved
.idea/runConfigurations/Run_build_runner.xml Outdated Show resolved Hide resolved
@maxammann maxammann merged commit d0957da into whitelabel Sep 19, 2022
@maxammann maxammann deleted the 517-add-build-config branch September 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants