Reenable rotation to and from landscape mode on Android

[maxammann]

fixes #419

[michael-markl]

I just installed the app-release.apk from https://app.circleci.com/pipelines/github/digitalfabrik/ehrenamtskarte/912/workflows/8920355f-b301-4e08-bc96-1f93d2031941/jobs/6414/artifacts, but I found the issue sitll persists. I can rotate the app again, but there is still an area (at the right side in my case) after rotating to landscape which is unresponsive. :/

[maxammann]

hm I suspect that I only fixed it for debug mode :/ I'll test it again.

[maxammann]

@Schedulaar feel free to test again :)

[michael-markl]

@maxammann I am sorry that I have to disappoint you, but it's still not working on my device :/

[maxammann]

hm that it weid worked in release mode on my device

[maxammann]

Oke, weird the ci build is not working 🤔

[maxammann]

I definitely have a release build which is working locally. But the CI build is not working

[maxammann]

@Schedulaar it seems only not to work if the intro slides are shown before that. Can you try to restart the app (latest build) and see whether the issue is still there?

[michael-markl]

Yep, it does indeed work after an app restart. However, I have noticed that sometimes (like 1 out of 50 times) there's a black screen where the map should be...

[maxammann]

Hm that is weird, maybe the black screen is even unrelated.

Last try is pushed. The change which I made is worth discussing. Maybe that is actually the better behavior for the app in general.
First start with the intro route in focus. After the intro slides are done, replace them with the main route. Before this PR the intro slide was "above" the main route.

[michael-markl]

This seems (almost) perfect! Having the intro slides not above the main route is way better in my opinion. That way, if the location permissions are given in the intro slides, the app will start initialized properly after finishing the intro slides.

[maxammann]

@Schedulaar I think my beauty if finished now. Maybe check one last time.

The black screen was actually introduced in my commits. I fixed this now.

[steffenkleinle]

@maxammann I'd review this tomorrow if you want :)

[michael-markl]

Again closer to perfect, but not yet exactly there: When I rotate to landscape (given I start the app in portrait mode), the info icon is again not shown (because the map's actual size is the huge square).

Accordingly, if the app is started in landscape mode and then rotated to portrait mode, the same thing happens.

[maxammann]

@Schedulaar thanks for noticing! I get now the correct constrains within the map should be placed.

[michael-markl]

Buttery smooth now 😍

[maxammann]

@klinzo feel free to test tomorrow :) then I'll merge this!

[steffenkleinle]

Tested on android, did not experience any unresponsiveness.