Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1202: Android invalid certificate #1203

Merged
merged 4 commits into from
Nov 14, 2023
Merged

1202: Android invalid certificate #1203

merged 4 commits into from
Nov 14, 2023

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Nov 9, 2023 •
edited
Loading

Short description

This pr adds a valid let's encrypt certificate to support https requests for android versions < 7.1.1.
Additional information can be found in the comment (code)

Proposed changes

  • add and load certificate

Testing

  • use an android emulator with android 7 or below
  • use production build of sozialpass or entitlement card
  • check if you can reach the backend

Resolved issues

Fixes: #1202

sarahsporck
sarahsporck approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android emulator. Works pretty well 👍🏼

frontend/lib/main.dart Outdated Show resolved Hide resolved
@f1sh1918 f1sh1918 requested a review from sarahsporck November 13, 2023 12:19
sarahsporck
sarahsporck approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this again and it still works. Nice :)

@f1sh1918 f1sh1918 merged commit 89d7d3a into main Nov 14, 2023
1 check passed
@f1sh1918 f1sh1918 deleted the 1202-android-invalid-certificate branch November 14, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahsporck sarahsporck sarahsporck approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android invalid certificate
2 participants
@f1sh1918 @sarahsporck