Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1029: Empty map auto screenshot #1183

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Oct 19, 2023

Short description

The map screenshot was just a white on some devices.

Proposed changes

  • Since newer iOS Versions at least on simulators need a signifcant longer loading time of the map i increased the sleep time before taking screenshot
  • i had to update some pods to get the screenshots working. Cocoapods 1.13.0 are required for xcode 15 f.e.
  • adjusted the detail test for nuernberg, since the stores differ to bavaria
  • updated to documentation to run tests for bavaria & nuernberg

Resolved issues

Fixes: #1029

docs/production-setup.md Outdated Show resolved Hide resolved
@f1sh1918 f1sh1918 merged commit 7b08a8b into main Nov 10, 2023
1 check passed
@f1sh1918 f1sh1918 deleted the 1029-empty-map-auto-screenshot branch November 10, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto screenshot for map shows empty map
2 participants