1080: Add start day #1090

f1sh1918 · 2023-08-17T13:35:16Z

resolves #1080

… protobuf, adjust card content to show date start, add stillInvalidCheck

sarahsporck

Tested on android emulator.

administration/src/project-configs/nuernberg/pdf.ts

frontend/lib/identification/card_detail_view/card_detail_view.dart

michael-markl

Imo, the start date must also be added to the DB table and checked in the backend.

specs/card.proto

michael-markl · 2023-08-20T16:10:26Z

You mean because you could change the time/date on the local device to make the card valid?
Hm couldn't we just add general check if the device date/timestamp fits to the backend timestamp?
Instead of checking each timestamp we add @michael-markl

Not sure what you mean by "each timestamp we add". I don't think there will be yet another timestamp in the future regarding the validity period.

Also I think, we should make sure that the backend has the (ultimate) capability of checking whether a card is valid or not (simply by looking at the row in the DB table). (Might also be interesting to have a statistic like "Currently valid cards" which we wouldn't be able to accurately determine if we don't add it to the DB). More importantly (imo), the verifyCard endpoint should always be correct and, hence, should also reflect whether the validity period has already started.

Implementing some validity checks on the frontend (of the verifier's device) and some validity checks on the backend seems a bit arbitrary to me from a design perspective.

…ding issue for card verification

michael-markl

Haven't tested

administration/src/cards/extensions/StartDayExtension.tsx

backend/src/main/kotlin/app/ehrenamtskarte/backend/migration/migrations/V0007_AddStartDay.kt

backend/src/main/kotlin/app/ehrenamtskarte/backend/verification/database/Schema.kt

frontend/test/card_info_util_test.dart

frontend/lib/identification/util/card_info_utils.dart

Co-authored-by: Michael Markl <[email protected]>

…n/database/Schema.kt Co-authored-by: Michael Markl <[email protected]>

…st for card info utils isCardNotYetValid, add a check that expiry date is after start day

frontend/test/card_info_util_test.dart

frontend/lib/identification/id_card/card_content.dart

administration/src/cards/extensions/StartDayExtension.tsx

sarahsporck

Again works as expected. I like the additional tests and checks. Checking the time is sth. we seemingly have overseen completely before.

michael-markl

Not tested

frontend/lib/identification/card_detail_view/card_detail_view.dart

…dart Co-authored-by: Michael Markl <[email protected]>

sarahsporck

I left some minor comments. Please rerequest review once you have updated the last changes, then I'll look over it (hopefully) one last time

administration/src/bp-modules/cards/AddCardForm.tsx

administration/src/cards/CardBlueprint.ts

…y checks

…dd-start-date

sarahsporck

👌🏼 nice work. works fine.

1080: add start day extension, add start day to csv, add start day to…

3eb3880

… protobuf, adjust card content to show date start, add stillInvalidCheck

f1sh1918 requested review from steffenkleinle and sarahsporck as code owners August 17, 2023 13:35

1080: fix uppercase vars

e4974f3

sarahsporck approved these changes Aug 18, 2023

View reviewed changes

administration/src/project-configs/nuernberg/pdf.ts Show resolved Hide resolved

frontend/lib/identification/card_detail_view/card_detail_view.dart Outdated Show resolved Hide resolved

michael-markl requested changes Aug 18, 2023

View reviewed changes

specs/card.proto Show resolved Hide resolved

f1sh1918 added 2 commits August 21, 2023 15:37

1076: add startDay column, add test for startDay, rename var, fix pad…

343e6be

…ding issue for card verification

1076: update graphql schema

68acf67

michael-markl reviewed Aug 21, 2023

View reviewed changes

f1sh1918 and others added 5 commits August 21, 2023 18:10

Update administration/src/cards/extensions/StartDayExtension.tsx

0981817

Co-authored-by: Michael Markl <[email protected]>

Update administration/src/cards/extensions/StartDayExtension.tsx

3d7ab9c

Co-authored-by: Michael Markl <[email protected]>

Update backend/src/main/kotlin/app/ehrenamtskarte/backend/verificatio…

9873353

…n/database/Schema.kt Co-authored-by: Michael Markl <[email protected]>

1076: fix minor issues

9b2ef9f

Merge remote-tracking branch 'origin/main' into 1080-add-start-date

bd4da2a

f1sh1918 requested a review from michael-markl August 21, 2023 18:12

1080: added test for administrtion card hash with startDate, added te…

2e276f0

…st for card info utils isCardNotYetValid, add a check that expiry date is after start day

f1sh1918 force-pushed the 1080-add-start-date branch from 4510f4b to 2e276f0 Compare August 21, 2023 19:46

f1sh1918 and others added 4 commits August 21, 2023 22:50

1080: log card hash

b5d34a1

1080: pass single extension, add TODO

fec7935

1080: remove form dependency

6a68f7d

Merge branch 'main' into 1080-add-start-date

ee66162

sarahsporck self-requested a review August 22, 2023 11:53

michael-markl reviewed Aug 22, 2023

View reviewed changes

frontend/test/card_info_util_test.dart Show resolved Hide resolved

frontend/lib/identification/id_card/card_content.dart Outdated Show resolved Hide resolved

administration/src/cards/extensions/StartDayExtension.tsx Outdated Show resolved Hide resolved

sarahsporck approved these changes Aug 22, 2023

View reviewed changes

f1sh1918 requested a review from michael-markl August 22, 2023 14:55

michael-markl approved these changes Aug 22, 2023

View reviewed changes

michael-markl reviewed Aug 22, 2023

View reviewed changes

1080: add check for form and csv if startDay is before expirationDay

1dbae00

f1sh1918 force-pushed the 1080-add-start-date branch from 7eab2ae to 1dbae00 Compare August 22, 2023 22:54

Update frontend/lib/identification/card_detail_view/card_detail_view.…

0366631

…dart Co-authored-by: Michael Markl <[email protected]>

sarahsporck reviewed Aug 23, 2023

View reviewed changes

administration/src/bp-modules/cards/AddCardForm.tsx Outdated Show resolved Hide resolved

administration/src/cards/CardBlueprint.ts Outdated Show resolved Hide resolved

f1sh1918 added 2 commits August 23, 2023 11:28

1080: move expiration check to cardBlueprint, adjust order of validit…

71a9d59

…y checks

Merge remote-tracking branch 'origin/1080-add-start-date' into 1080-a…

6d8fd6c

…dd-start-date

f1sh1918 requested a review from sarahsporck August 23, 2023 09:31

f1sh1918 and others added 3 commits August 23, 2023 13:34

Merge branch 'main' into 1080-add-start-date

31b7803

1080: move card notYetValid before invalid for CardStatus

03af797

Merge remote-tracking branch 'origin/1080-add-start-date' into 1080-a…

2a7061a

…dd-start-date

sarahsporck approved these changes Aug 23, 2023

View reviewed changes

f1sh1918 merged commit 59dbdf3 into main Aug 23, 2023

f1sh1918 deleted the 1080-add-start-date branch August 23, 2023 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1080: Add start day #1090

1080: Add start day #1090

f1sh1918 commented Aug 17, 2023

sarahsporck left a comment

michael-markl left a comment

michael-markl commented Aug 20, 2023 •

edited

Loading

michael-markl left a comment

sarahsporck left a comment

michael-markl left a comment

sarahsporck left a comment

sarahsporck left a comment

1080: Add start day #1090

1080: Add start day #1090

Conversation

f1sh1918 commented Aug 17, 2023

sarahsporck left a comment

Choose a reason for hiding this comment

michael-markl left a comment

Choose a reason for hiding this comment

michael-markl commented Aug 20, 2023 • edited Loading

michael-markl left a comment

Choose a reason for hiding this comment

sarahsporck left a comment

Choose a reason for hiding this comment

michael-markl left a comment

Choose a reason for hiding this comment

sarahsporck left a comment

Choose a reason for hiding this comment

sarahsporck left a comment

Choose a reason for hiding this comment

michael-markl commented Aug 20, 2023 •

edited

Loading