1030: Incomplete data privacy #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal text if no region specific text is provided
f1sh1918
force-pushed
the
1030-incomplete-data-privacy-policy
branch
from
483a5f5 to
b492226
Compare
michael-markl
approved these changes
Jun 28, 2023
| @@ -449,11 +449,16 @@ export const DataPrivacyBaseText = () => ( | |||
| Informationen, die Sie unverschlüsselt per E-Mail an uns senden können, möglicherweise auf dem Übertragungsweg von | |||
| Dritten gelesen werden.{' '} | |||
| </p> | |||
| <p style={{ marginTop: '0pt', marginBottom: '8pt' }}> | |||
| <div> | |||
There was a problem hiding this comment.
Should we readd the margin bottom here?
There was a problem hiding this comment.
hm its very inconsistent in the template. the sections directly above do not use the margin after the headline. so it looks weird imo
| ) | ||
|
|
||
| export const DataPrivacyAdditionalBaseText = () => ( | ||
| <div> |
There was a problem hiding this comment.
Should we make this a p? Or is some manual margin necessary?
There was a problem hiding this comment.
we could add some bottom margin, but on the other hand if the region specific text gonna be added there won't be any margin neither. I think it's fine as it is. Since we have the container padding of the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1030